Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 (#593) #594

Merged
merged 1 commit into from
Sep 28, 2022
Merged

feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 (#593) #594

merged 1 commit into from
Sep 28, 2022

Conversation

DandreChen
Copy link
Collaborator

@DandreChen DandreChen commented Sep 28, 2022 •
edited by RingsC
Loading

Summary about this PR

1 SELECT_LEX->braces is used in MySQL5.7, at optimize part, but deleted in MySQL 8.0
2 in MySQL 8.0, use Query_expression->is_union() instead of SELECT_LEX->braces

Issue Number: close #593

Tests Check List

  • [] Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 28, 2022
@DandreChen DandreChen changed the title feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 (#593) Sep 28, 2022
@DandreChen
feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0. (ston…
6f15a62 
…eatom#593)

[summary]
1 SELECT_LEX->braces is used in MySQL5.7, at optimize part, but deleted in MySQL 8.0
2 in MySQL 8.0, use Query_expression->is_union() instead of SELECT_LEX->braces
hustjieke
hustjieke approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify mergify bot merged commit e38e73e into stoneatom:stonedb-8.0-dev Sep 28, 2022
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

@andyli029 andyli029 Awaiting requested review from andyli029

@isredstar isredstar Awaiting requested review from isredstar

@lujiashun lujiashun Awaiting requested review from lujiashun

Assignees

@DandreChen DandreChen

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DandreChen @RingsC @hustjieke @Nliver