Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoneDB 8.0): remove 'build' from .gitignore file. (#629) #630

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Sep 30, 2022

Summary about this PR

Issue Number: close #629

remove 'build' from .gitignore file.
'build' directory is created in build stage,and files in build direcotry will not be updated because of the .gitignore file.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

[summary]
1 build is created in build stage,and will not be updated because of the .gitignore file.
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 30, 2022
@lujiashun lujiashun self-assigned this Sep 30, 2022
@lujiashun lujiashun added the C-stonedb-8.0 associated with stonedb 8.0 label Sep 30, 2022
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 69b429e into stoneatom:stonedb-8.0-dev Sep 30, 2022
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-stonedb-8.0 associated with stonedb 8.0 PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants