Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql-test): add_comlumn test failed #648 #651

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Oct 8, 2022

[summary]

  1. rm Deprecate integer display warnings as --nowarnings does not take effect in 8.0. For more details, see: https://dev.mysql.com/worklog/task/?id=13127
  2. port missing std_data and files in mysql-test from stonedb-5.7-dev.
  3. fix uncorrect result of concat test.

Summary about this PR

Issue Number: close #648

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

[summary]
1. rm `Deprecate integer display` warnings as --nowarnings does not take effect in 8.0.
For more details, see: https://dev.mysql.com/worklog/task/?id=13127
2. port missing std_data and files in mysql-test from stonedb-5.7-dev.
3. fix uncorrect result of concat test.
@hustjieke hustjieke force-pushed the bug_fix_add_column_failed_issue648 branch from b6f1ba4 to 688c05d Compare October 8, 2022 09:17
@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Oct 8, 2022
@hustjieke hustjieke changed the title fix: add_comlumn test failed #648 fix(mysql-test): add_comlumn test failed #648 Oct 8, 2022
different env.

[summary]
When executing `show create table ...`
1. In ubuntu 20.04 or centos 7, we may got `DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci`.
2. In local ubuntu 20.04, we got DEFAULT CHARSET=utf8mb3.
@hustjieke hustjieke marked this pull request as ready for review October 9, 2022 07:13
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 888d9c9 into stoneatom:stonedb-8.0-dev Oct 9, 2022
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants