Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoneDB 8.0): Fix up format-security/class-memaccess warnings. (#547) #655

Merged

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Oct 8, 2022

Summary about this PR

Issue Number: ref #547

feat(StoneDB 8.0): Fix up format-security/class-memaccess warnings. (#547)

1 fix "warning: declaration ‘class Tianmu::compress::PartDict::HashTab::AKey’ does not declare anything";
2 fix "log_ctl.h:49:112: warning: format not a string literal and no format arguments [-Wformat-security]";
3 fix class-memaccess warning;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@lujiashun lujiashun added the C-stonedb-8.0 associated with stonedb 8.0 label Oct 8, 2022
@lujiashun lujiashun self-assigned this Oct 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Oct 8, 2022
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…toneatom#547)

[summary]
1 fix "warning: declaration ‘class Tianmu::compress::PartDict::HashTab::AKey’ does not declare anything";
2 fix "log_ctl.h:49:112: warning: format not a string literal and no format arguments [-Wformat-security]";
3 fix class-memaccess warning;
@lujiashun lujiashun force-pushed the feat-547-format-security branch from 292a797 to a9b6e82 Compare October 8, 2022 12:16
@lujiashun lujiashun changed the title feat(StoneDB 8.0): Fix up format-security warnings. (#547) feat(StoneDB 8.0): Fix up format-security/class-memaccess warnings. (#547) Oct 8, 2022
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 546380a into stoneatom:stonedb-8.0-dev Oct 9, 2022
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-stonedb-8.0 associated with stonedb 8.0 PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants