Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(tianmu): check whether there is least one tianmu table in Query_expression (#708) #709

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #708

[summary]
delete the assert code, add tianmu table judgment

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

…n Query_expression (stoneatom#708)

delete the assert code, add tianmu table judgment
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2022

This pull request's title should follow requirements next. @DandreChen please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@DandreChen DandreChen added the C-stonedb-8.0 associated with stonedb 8.0 label Oct 12, 2022
@DandreChen DandreChen added this to the stonedb_8.0_v1.0.0 milestone Oct 12, 2022
@RingsC RingsC changed the title feature(StoneDB 8.0): check whether there is least one tianmu table in Query_expression (#708) feature(tianmu): check whether there is least one tianmu table in Query_expression (#708) Oct 12, 2022
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f15a0b1 into stoneatom:stonedb-8.0-dev Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-stonedb-8.0 associated with stonedb 8.0
Projects
Development

Successfully merging this pull request may close these issues.

3 participants