Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StoneDB 8.0): adapt testcase insert_select.test/flow_control_function.test. (#777) #799

Merged
merged 2 commits into from
Oct 27, 2022
Merged

feat(StoneDB 8.0): adapt testcase insert_select.test/flow_control_function.test. (#777) #799

merged 2 commits into from
Oct 27, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Oct 25, 2022 •
edited
Loading

Summary about this PR

Issue Number: close #777

1 fix insert_select.test crash in debug mode;
compared with stonedb5.7 flow, add prepare_for_positional_update in Query_result_insert::prepare;
2 fix "flow_control_function.test" failed in debug mode;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@lujiashun lujiashun self-assigned this Oct 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Oct 25, 2022
@lujiashun lujiashun force-pushed the feat-777 branch 2 times, most recently from 9a3a8c0 to e912752 Compare October 25, 2022 09:05
@lujiashun lujiashun changed the title feat(StoneDB 8.0): adapt testcase insert_select.test. (#777) feat(StoneDB 8.0): adapt testcase insert_select.test/flow_control_function.test. (#777) Oct 25, 2022
DandreChen
DandreChen approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lujiashun lujiashun marked this pull request as draft October 26, 2022 10:19
@lujiashun lujiashun marked this pull request as ready for review October 26, 2022 10:24
RingsC
RingsC suggested changes Oct 27, 2022
View reviewed changes
mysql-test/suite/tianmu/t/flow_control_function.test Outdated Show resolved Hide resolved
sql/sql_insert.cc Outdated Show resolved Hide resolved
feat(StoneDB 8.0): adapt mtr insert_select.test/flow_control_function…
35e57df 
….test. (stoneatom#777)

[summary]
1 fix insert_select.test crash in debug mode;
  compared with stonedb5.7 flow, add prepare_for_positional_update in Query_result_insert::prepare;
2 fix "flow_control_function" failed in debug mode;
RingsC
RingsC approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great Job

@mergify mergify bot merged commit f535754 into stoneatom:stonedb-8.0-dev Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DandreChen DandreChen DandreChen approved these changes

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

Assignees

@lujiashun lujiashun

Labels
PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lujiashun @RingsC @DandreChen