feat(tianmu): support 'ALTER TABLE t1 CHARACTER SET = ...' clause. (#848) #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
|
@lujiashun , Pls, add more specific information about this PR. such as this PR can slove what and not , etc. Thanks. |
lujiashun
force-pushed
the
feat-848
branch
2 times, most recently
from
232ced8 to
478cf5e
Compare
…toneatom#848) [summary] 1 add implement in check_if_supported_inplace_alter of tianmu handler; 2 add implement in inplace_alter_table of tianmu handler; 3 add implement in commit_inplace_alter_table of tianmu handler;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #848
1 add implement in check_if_supported_inplace_alter of tianmu handler;
2 add implement in inplace_alter_table of tianmu handler;
3 add implement in commit_inplace_alter_table of tianmu handler;
4. add mtr of ’atler table ... character set/atler table modify ... character set/atler table change ...character set';
https://dev.mysql.com/doc/refman/5.7/en/alter-table.html#alter-table-character-set
To change only the default character set for a table, use this statement:
ALTER TABLE tbl_name DEFAULT CHARACTER SET charset_name;
The word DEFAULT is optional. The default character set is the character set that is used if you do not
specify the character set for columns that you add to a table later (for example, with ALTER TABLE ...
ADD column)
Tests Check List
Changelog
Documentation