fix(tianmu): fix problems related to master slave synchronization (#819) #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
konghaiya
force-pushed
the
dev_lhj_819_2
branch
from
5445dd0 to
4eb5bf5
Compare
|
CR, PTAL, @RingsC @hustjieke @isredstar @duanfuxiang0 |
konghaiya
force-pushed
the
dev_lhj_819_2
branch
from
4eb5bf5 to
e77fea1
Compare
hustjieke
reviewed
Nov 3, 2022
|
@konghaiya pls fix the review comment. |
konghaiya
force-pushed
the
dev_lhj_819_2
branch
3 times, most recently
from
25cf2b1 to
d00a3fb
Compare
konghaiya
changed the title
konghaiya
force-pushed
the
dev_lhj_819_2
branch
2 times, most recently
from
2c8d24a to
04da0c4
Compare
…oneatom#819) fix 1:stoneatom#818 Master slave synchronization - There will be too many tuples problem Cause: Tianmu::dbhandler::TianmuHandler::current_position This variable is not initialized. In some cases, a large value may cause too many tuples problem. Solution: Initialize the variable fix 2:stoneatom#819 Master slave synchronization - Primary key conflict problem Solution: Modify the modification logic of master slave synchronization, so that the delete and update operations do not follow the primary key logic Supplement sql/sql_insert.cc Fix the problem that the insert statement will not generate binlog in the delayed insert mode storage/tianmu/handler/tianmu_handler.cpp Fix the binlog error of the line format generated by the tianmu engine
konghaiya
force-pushed
the
dev_lhj_819_2
branch
from
04da0c4 to
bacd9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 1:#818 Master slave synchronization - There will be too many tuples problem
Cause:
Tianmu::dbhandler::TianmuHandler::current_position This variable is not initialized. In some cases, a large value may cause too many tuples problem.
Solution: Initialize the variable
fix 2:#819 Master slave synchronization - Primary key conflict problem
Solution: Modify the modification logic of master slave synchronization, so that the delete and update operations do not follow the primary key logic
Supplement
sql/sql_insert.cc
Fix the problem that the insert statement will not generate binlog in the delayed insert mode storage/tianmu/handler/tianmu_handler.cpp
Fix the binlog error of the line format generated by the tianmu engine
Summary about this PR
Issue Number: close #issue_number_you_created
Tests Check List
Changelog
Documentation