Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add c char(10) (#760) #901

Merged
merged 1 commit into from
Nov 10, 2022
Merged

feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add c char(10) (#760) #901

merged 1 commit into from
Nov 10, 2022

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #760

[summary]
fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 8, 2022
RingsC
RingsC suggested changes Nov 9, 2022
View reviewed changes
storage/tianmu/core/temp_table.h Outdated Show resolved Hide resolved
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 3 times, most recently from e60700d to 9b6bd0a Compare November 9, 2022 05:49
duanfuxiang0
duanfuxiang0 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DandreChen DandreChen requested a review from RingsC November 10, 2022 03:12
RingsC
RingsC approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@DandreChen DandreChen self-assigned this Nov 10, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
e1910bd 
…c char(10) (stoneatom#760)

fix some warnings
add/fix mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
@mergify mergify bot merged commit 02cb94c into stoneatom:stonedb-5.7-dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duanfuxiang0 duanfuxiang0 duanfuxiang0 approved these changes

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

@lujiashun lujiashun Awaiting requested review from lujiashun

Assignees

@DandreChen DandreChen

Labels
PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Dose not support the ALTER syntax, ALTER table t1 rename t2, add c char(10);
3 participants
@DandreChen @RingsC @duanfuxiang0