Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): uniform variable name #11 #905

Merged

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Nov 8, 2022

Summary about this PR

1.uniform class member name on transaction code.
2.uniform member name on pack code.
3.change tid to table_id.
Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 8, 2022
@hustjieke hustjieke force-pushed the feat_uniform_txn_packs_tid_5.7 branch from c085353 to 61eab8d Compare November 11, 2022 07:11
[summary]
1.uniform class member name on transaction code.
2.uniform member name on pack code.
3.change tid to table_id.
@hustjieke hustjieke force-pushed the feat_uniform_txn_packs_tid_5.7 branch from 61eab8d to 97b990e Compare November 11, 2022 07:37
@hustjieke hustjieke marked this pull request as ready for review November 11, 2022 07:55
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6619c83 into stoneatom:stonedb-5.7-dev Nov 17, 2022
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants