Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix query syntax (WHERE NOT IN ) is not supported. (#767) #910

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Nov 9, 2022

Summary about this PR

Issue Number: ref #767
[summary]
1 root cause: sub-select item is the left argument,not the right argument of item_func;
2 "in" clause is a liltte different from "not in" clause, This PR just deal with "not in" clause;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Nov 9, 2022
@lujiashun lujiashun marked this pull request as draft November 9, 2022 12:01
@lujiashun lujiashun force-pushed the fix-767 branch 2 times, most recently from ebcf832 to d795e0a Compare November 11, 2022 06:03
@lujiashun lujiashun marked this pull request as ready for review November 11, 2022 06:34
mysql-test/suite/tianmu/t/issue767.test Outdated Show resolved Hide resolved
storage/tianmu/core/query.cpp Outdated Show resolved Hide resolved
@lujiashun
Copy link
Author

The sql "in" clause is not support,Its data structure is different from ”not in“ clause. Deal it later.

use test;
drop table if exist t1;
create table t1(val int) ENGINE=tianmu;
insert into t1 values(12);
select * from t1 where 42  in (select * from t1 where val > 42);

@lujiashun lujiashun force-pushed the fix-767 branch 2 times, most recently from 94e4b0d to 2e10d61 Compare November 15, 2022 04:26
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great job.

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1249a14 into stoneatom:stonedb-5.7-dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants