Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tianmu): The Tianmu engine supports user defined function (#538) #929

Merged
merged 1 commit into from
Nov 14, 2022
Merged

feat(tianmu): The Tianmu engine supports user defined function (#538) #929

merged 1 commit into from
Nov 14, 2022

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Nov 14, 2022

Summary about this PR

The Tianmu engine supports user defined function.
Issue Number: close #538

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2022

This pull request's title should follow requirements next. @adofsauron please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@adofsauron adofsauron changed the title feat(tianmu): The Tianmu engine supports user defined function (#538) feat(tianmu): feat The Tianmu engine supports user defined function (#538) Nov 14, 2022
@RingsC RingsC changed the title feat(tianmu): feat The Tianmu engine supports user defined function (#538) feat(tianmu): The Tianmu engine supports user defined function (#538) Nov 14, 2022
Supports user-defined functions and is compatible with mysql scalar data.
This version does not support composite data types such as json.

The solution of generating derived tables without collections
for custom functions is currently quite radical,
and a more elegant solution will be completed in the next iteration.
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit cb1e716 into stoneatom:stonedb-5.7-dev Nov 14, 2022
@Nliver Nliver added the PR-feature feature for pull request label Apr 15, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

feature: The Tianmu engine supports user defined function
4 participants