Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): fix crashed when the subquery includes a SORT clause (#906) #931

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix(tianmu): fix crashed when the subquery includes a SORT clause (#906) #931

merged 1 commit into from
Nov 16, 2022

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Nov 14, 2022 •
edited by RingsC
Loading

Summary about this PR

fix(tianmu): fix crashed when the subquery includes a SORT clause (#906)
the reason is The subquery generates a temp table, 
but the count(*) column of the subquery is not a physical column, 
so the interface is incompatible.
so if the virtual column does not point to the physical column, 
the check is not performed

Issue Number: close #906

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Nov 14, 2022
RingsC
RingsC suggested changes Nov 14, 2022
View reviewed changes
mysql-test/suite/tianmu/t/issue906.test Show resolved Hide resolved
mysql-test/suite/tianmu/t/issue906.test Show resolved Hide resolved
storage/tianmu/core/temp_table.h Outdated Show resolved Hide resolved
@adofsauron
fix(tianmu): fix crashed when the subquery includes a SORT clause (#906
dbcdce3 
)

    the reason is The subquery generates a temp table,
    but the count(*) column of the subquery is not a physical column,
    so the interface is incompatible.
    so if the virtual column does not point to the physical column,
    the check is not performed
@adofsauron adofsauron requested a review from RingsC November 15, 2022 03:48
RingsC
RingsC approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hustjieke
hustjieke approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1f86173 into stoneatom:stonedb-5.7-dev Nov 16, 2022
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

Assignees

@adofsauron adofsauron

Labels
PR-bug bug for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.2
Development

Successfully merging this pull request may close these issues.

bug:The instance crashed because the subquery includes a SORT clause but it cannot be flattened.
4 participants
@adofsauron @RingsC @hustjieke @Nliver