feat: bump ui kit #392
Merged
feat: bump ui kit #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallachari
approved these changes
May 13, 2020
| @@ -1,7 +1,8 @@ | |||
| import { IHttpConfig, IHttpOperationConfig } from '@stoplight/prism-http'; | |||
| import * as PrismClient from '@stoplight/prism-http/dist/client'; | |||
| import { Dictionary, IHttpOperation, IHttpRequest } from '@stoplight/types'; | |||
| import axios, { CancelTokenSource } from 'axios'; | |||
| import type { CancelTokenSource } from 'axios'; | |||
There was a problem hiding this comment.
This import type is interesting - I didn't see that before. Might be useful.
There was a problem hiding this comment.
This is actually a workaround, should not be normally needed. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html
The reason I had to split that import is to make sure we avoid TS generating an __importStar invocation. This is what I was stuck on yesterday for like 4 hours: microsoft/TypeScript#38540
|
🎉 This PR is included in version 6.0.0-beta.45 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the new TableOfContents features from
ui-kit.