feat: STOP-243 - create prism instance with full spec #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendarearden
commented
Mar 20, 2024
| @@ -640,7 +640,7 @@ describe('body params validation', () => { | |||
| }); | |||
|
|
|||
| describe('and size bigger than 10MB', () => { | |||
| test('returns 422', async () => { | |||
| test('returns 413', async () => { | |||
There was a problem hiding this comment.
this was checking a 413, so I updated the title to match.
the rest of the changes in this file are formatting changes
brendarearden
changed the title
brendarearden
commented
Mar 20, 2024
daniel-white
suggested changes
Mar 20, 2024
daniel-white
suggested changes
Mar 20, 2024
brendarearden
commented
Mar 21, 2024
| }, | ||
| }; | ||
| const result = decycle( | ||
| await new $RefParser().dereference(specFilePathOrObject, { resolve: { http: httpResolverOpts } }) |
There was a problem hiding this comment.
@daniel-white we are going to leave this here and then add a check for unresolved external references in our usage of this code and error at that point.
EdVinyard
approved these changes
Mar 21, 2024
…m code that assumes the request came in from a socket
brendarearden
force-pushed
the
feat/STOP-243-mock-accept-full-spec
branch
from
58f75fe
to
81bfbe8
Compare
brendarearden
force-pushed
the
feat/STOP-243-mock-accept-full-spec
branch
from
81bfbe8
to
794b321
Compare
daniel-white
approved these changes
Mar 22, 2024
brendarearden
changed the title
Merged
This was referenced Apr 29, 2024
Closed
Closed
This was referenced Jul 2, 2024
Merged
Merged
Closed
This was referenced Aug 8, 2024
Merged
Merged
ilanashapiro
pushed a commit
to ilanashapiro/prism
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Ed Vinyard <ed@stoplight.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: STOP-243
Summary
Introduces
createAndCallPrismInstanceWithSpecthat allows you to pass in a prism config, prism request and an oas spec path or document and get a prism response or an error string back.Checklist