-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Dockerfile to node:18 #2515
Conversation
@kaylachun Friendly ping on this CL. Thanks! |
@@ -1,4 +1,4 @@ | |||
FROM node:16 as compiler | |||
FROM node:18.20.1 as compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we want to be this specific - node:18
should be sufficent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-white, according to https://www.cve.org/CVERecord?id=CVE-2024-27983 version 18.20.0 is affected. That is why @landrito used the higher version if I'm not mistaken.
Hi @kaylachun, Our team is attempting to release a feature that is dependent on the Prism Docker image in Docker Hub. However, we were unable to obtain approval from our security team due to the unresolved vulnerabilities on the docker image. With this merge, we're hoping that you'll be cutting a new version and releasing it to docker hub soon. Do you have an ETA? Thank you for your help! |
@landrito, the new version was released a minute ago: https://github.com/stoplightio/prism/releases/tag/v5.8.0 Let us know if it fixes your issue. Thank you for your contribution! |
Thanks!! |
Addresses #2514
Summary
Upgrades base image in Dockerfile to
node:18.20.1
to resolve vulnerabilities flagged on the docker image.Checklist
Screenshots
N/A
Additional context
N/A