Skip to content

Commit

Permalink
fixup! fix: Have separate Lint checks for push and pull requests
Browse files Browse the repository at this point in the history
  • Loading branch information
nulltoken committed Apr 26, 2020
1 parent c716971 commit 0655244
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/octokit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ export const updateGithubCheck = (
info(JSON.stringify(check, undefined, 2));
info('++++++++++++++++++++++++++++++++++++++');

const summary =
message ?? conclusion === 'success' ? 'Lint completed successfully' : 'Lint completed with some errors';

const response = await octokit.checks.update({
check_run_id: check.data.id,
owner: event.owner,
Expand All @@ -80,7 +77,11 @@ export const updateGithubCheck = (
completed_at: new Date().toISOString(),
output: {
title: event.eventName,
summary,
summary: message
? message
: conclusion === 'success'
? 'Lint completed successfully'
: 'Lint completed with some errors',
// TODO: Split calls when annotations.length > 50
// From https://octokit.github.io/rest.js/v17#checks-update
// => "The Checks API limits the number of annotations to a maximum of 50 per API request.
Expand Down

0 comments on commit 0655244

Please sign in to comment.