fix: check for presence of operationId

stoplightio · Nov 30, 2020 · 177d3ab · 177d3ab
1 parent f51a6b0
commit 177d3ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/rulesets/oas/functions/oasOpIdUnique.ts b/src/rulesets/oas/functions/oasOpIdUnique.ts
@@ -9,16 +9,20 @@ export const oasOpIdUnique: IFunction = targetVal => {
   const seenIds: unknown[] = [];
 
   for (const { path, operation } of getAllOperations(paths)) {
+    if (!('operationId' in paths[path][operation])) {
+      continue;
+    }
+
     const { operationId } = paths[path][operation];
 
     if (seenIds.includes(operationId)) {
       results.push({
         message: 'operationId must be unique.',
         path: ['paths', path, operation, 'operationId'],
       });
+    } else {
+      seenIds.push(operationId);
     }
-
-    seenIds.push(operationId);
   }
 
   return results;

diff --git a/test-harness/scenarios/severity/fail-on-error.oas3.scenario b/test-harness/scenarios/severity/fail-on-error.oas3.scenario
@@ -30,7 +30,6 @@ OpenAPI 3.x detected
   2:6   warning  info-description              OpenAPI object info `description` must be present and non-empty string.  info
   7:9   warning  operation-description         Operation `description` must be present and non-empty string.            paths./test.get
   7:9   warning  operation-tags                Operation should have non-empty `tags` array.                            paths./test.get
-  8:20    error  operation-operationId-unique  Every operation must have a unique `operationId`.                        paths./test.get.operationId
   10:9    error  parser                        Mapping key must be a string scalar rather than number                   paths./test.get.responses[200]
  12:10  warning  operation-description         Operation `description` must be present and non-empty string.            paths./test.post
  12:10  warning  operation-tags                Operation should have non-empty `tags` array.                            paths./test.post