fix: allow path-keys-no-trailing-slash empty slash (#85)

stoplightio · Feb 4, 2019 · 33a4a06 · 33a4a06
1 parent 5900c3a
commit 33a4a06
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/rulesets/oas/__tests__/__snapshots__/path-keys-no-trailing-slash.ts.snap b/src/rulesets/oas/__tests__/__snapshots__/path-keys-no-trailing-slash.ts.snap
@@ -3,7 +3,7 @@
 exports[`path-keys-no-trailing-slash return errors if path ends with a slash 1`] = `
 Array [
   Object {
-    "message": "must not match the pattern '/$'",
+    "message": "must not match the pattern '.+\\\\/$'",
     "name": "path-keys-no-trailing-slash",
     "path": Array [
       "paths",

diff --git a/src/rulesets/oas/__tests__/path-keys-no-trailing-slash.ts b/src/rulesets/oas/__tests__/path-keys-no-trailing-slash.ts
@@ -26,4 +26,12 @@ describe('path-keys-no-trailing-slash', () => {
     });
     expect(results.results).toMatchSnapshot();
   });
+
+  test('does not return error if path IS a /', () => {
+    const results = s.run({
+      swagger: '2.0',
+      paths: { '/': {} },
+    });
+    expect(results.results.length).toEqual(0);
+  });
 });
diff --git a/src/rulesets/oas/index.ts b/src/rulesets/oas/index.ts
@@ -329,7 +329,7 @@ export const commonOasRules = (): RuleCollection => ({
       field: '@key',
       function: RuleFunction.PATTERN,
       functionOptions: {
-        notMatch: '/$',
+        notMatch: '.+\\/$',
       },
     },
     tags: ['given'],