Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow path-keys-no-trailing-slash empty slash #85

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

marbemac
Copy link
Contributor

@marbemac marbemac commented Jan 31, 2019

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce?

Fix

What is the current behavior?

closes #79

Does this PR introduce a breaking change?

No

@marbemac marbemac requested a review from tbarn January 31, 2019 05:50
Copy link
Contributor

@tbarn tbarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and looks good 👍 .

@tbarn tbarn merged commit 3f7af7d into next Feb 1, 2019
@tbarn tbarn deleted the fix/path-keys-no-trailing-slash branch February 5, 2019 21:58
karol-maciaszek added a commit that referenced this pull request Feb 19, 2019
* fix: a typo and a probable cut-and-paste error

src/rulesets/oas3/index.ts and associated tests:

'specifcication' -> 'specification' in a comment
`servers` must be, and is tested against, being an array not a string

* fix: allow path-keys-no-trailing-slash empty slash (#85)

* fix: add operation-operationId-valid-in-url (#86)

to check for valid url characters in operationId

* fix: SL-1709 paths emitted by ajv are not json pointers

* fix: SL-1709 fixed json dependency version
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants