feat(ruleset-bundler): skypack plugin accepts ignore list (#2318)

stoplightio · Oct 24, 2022 · 6e6d0de · 6e6d0de
1 parent caedff1
commit 6e6d0de
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 10 deletions.
diff --git a/packages/ruleset-bundler/src/plugins/__tests__/skypack.spec.ts b/packages/ruleset-bundler/src/plugins/__tests__/skypack.spec.ts
@@ -124,4 +124,38 @@ fs.writeFileSync(path.join(__dirname, './output.js'), 'export default {}');
 `);
     });
   });
+
+  it('should respect ignore list', async () => {
+    serveAssets({
+      '/tmp/input.js': `import { createRulesetFunction } from '@stoplight/spectral-core/ruleset/validation';
+import { parse } from '@stoplight/yaml';
+import { isPlainObject } from '@stoplight/json';
+
+export default createRulesetFunction({}, input => {
+  assert.ok(isPlainObject(parse(input)));
+})
+`,
+    });
+
+    const code = await bundleRuleset('/tmp/input.js', {
+      target: 'browser',
+      plugins: [
+        skypack({
+          ignoreList: [/^@stoplight\/spectral-/, '@stoplight/json'],
+        }),
+        virtualFs(io),
+      ],
+    });
+
+    expect(code).toEqual(`import { createRulesetFunction } from '@stoplight/spectral-core/ruleset/validation';
+import { parse } from 'https://cdn.skypack.dev/@stoplight/yaml';
+import { isPlainObject } from '@stoplight/json';
+
+var input = createRulesetFunction({}, input => {
+  assert.ok(isPlainObject(parse(input)));
+});
+
+export { input as default };
+`);
+  });
 });
diff --git a/packages/ruleset-bundler/src/plugins/skypack.ts b/packages/ruleset-bundler/src/plugins/skypack.ts
@@ -4,15 +4,21 @@ import { isURL } from '@stoplight/path';
 
 const DATA_URIS = /^(?:data|node|file):/;
 
-export const skypack = (): Plugin => ({
-  name: '@stoplight-spectral/skypack',
-  resolveId(id) {
-    if (DATA_URIS.test(id) || isURL(id)) return;
+export const skypack = (opts?: { ignoreList?: (string | RegExp)[] }): Plugin => {
+  return <Plugin>{
+    name: '@stoplight-spectral/skypack',
+    resolveId(id) {
+      if (DATA_URIS.test(id) || isURL(id)) return;
 
-    if (isPackageImport(id)) {
-      return `https://cdn.skypack.dev/${id}`;
-    }
+      const isIgnored =
+        opts?.ignoreList !== void 0 &&
+        opts.ignoreList.some(ignored => (typeof ignored === 'string' ? ignored === id : ignored.test(id)));
 
-    return;
-  },
-});
+      if (!isIgnored && isPackageImport(id)) {
+        return `https://cdn.skypack.dev/${id}`;
+      }
+
+      return;
+    },
+  };
+};