fix: normalize documentUri #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@P0lip Thanks! However, I'm a bit lost here. How come this was only happening on Windows? |
We didn't normalize the document source, so deduping by fingerprint was failing due to path differences (slashes). |
P0lip
force-pushed
the
fix/pass-document-uri
branch
from
d22fae3
to
4e0386c
Compare
P0lip
force-pushed
the
fix/pass-document-uri
branch
from
4e0386c
to
445ed0b
Compare
|
Based on that, I decided to slightly tweak the code so the actual change is more clear, as indeed it wasn't obvious at first glance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 tests seem to fail regularly on CI (Windows).
I thought they were flaky, yet it turns out we have a minor issue here.
Minor, cause it may only happen when Spectral is used programmatically and a plain string is passed to
run& $ref resolving takes place.Checklist
Does this PR introduce a breaking change?