feat(cli): introduce --fail-on-unmatched-globs flag #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
feat/fail-on-unmatched-globs
branch
from
882f7e7 to
e9eb3cd
Compare
philsturgeon
reviewed
Oct 5, 2020
|
Ok let’s do things one step at a time. Deprecate old flag and introduce this flag, then remove the old way in the next major, then flip new behavior default on in the major after that. OSS! 😅
…--
Phil Sturgeon
DevRel @ Stoplight.io
On Oct 6, 2020, at 12:55, Jakub Rożek ***@***.***> wrote:
@P0lip commented on this pull request.
In docs/guides/2-cli.md:
> @@ -35,6 +35,7 @@ Other options include:
[boolean] [default: false]
--ignore-unknown-format do not warn about unmatched formats [boolean] [default: false]
--show-unmatched-globs show unmatched glob patterns [boolean] [default: false]
+ --fail-on-unmatched-globs fail on unmatched glob patterns [boolean] [default: false]
Should we deprecate show-unmatched-globs and have this be the new "more better" way of doing it?
Yeah, that'd be a good idea.
By the way, ESLint exits with non-zero code by default if any of the provided glob patterns is not matched.
Example:
$ eslint --cache --cache-location .cache/ --ext=.js,.ts src test-harness b
Oops! Something went wrong! :(
ESLint: 6.8.0.
No files matching the pattern "b" were found.
Please check for typing mistakes in the pattern.
error Command failed with exit code 2.
IMHO Spectral could do the same.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
philsturgeon
approved these changes
Oct 8, 2020
P0lip
added a commit
that referenced
this pull request
Nov 1, 2020
* feat(cli): introduce --fail-on-unmatched-globs flag * chore: deprecate show-unmatched-globs Co-authored-by: Phil Sturgeon <phil@stoplight.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1117
Checklist
Does this PR introduce a breaking change?