Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address Webpack warning #1458

Merged
merged 2 commits into from
Jan 12, 2021
Merged

fix: address Webpack warning #1458

merged 2 commits into from
Jan 12, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jan 8, 2021

Fixes #1431

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip self-assigned this Jan 8, 2021
@P0lip P0lip added the t/bug Something isn't working label Jan 8, 2021
@P0lip P0lip requested review from philsturgeon and a team January 8, 2021 00:53
@billiegoose
Copy link
Contributor

This raises so many eyebrows, I've run out of eyebrows to raise.

@P0lip P0lip force-pushed the fix/no-webpack-warnings branch from 1f15895 to 92411d1 Compare January 8, 2021 08:40
@P0lip P0lip force-pushed the fix/no-webpack-warnings branch from 92411d1 to e97ae94 Compare January 8, 2021 11:07
@philsturgeon
Copy link
Contributor

But why? :D

@billiegoose
Copy link
Contributor

Can I suggest doing it properly?

billiegoose
billiegoose approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh screw it. nobody uses CSP amirite?

@P0lip
Copy link
Contributor Author

P0lip commented Jan 12, 2021 •
edited
Loading

eh screw it. nobody uses CSP amirite?

Yeah. Honestly, I'm planning to go away from require calls and organize the project (thinking seriously of monorepo) a bit better to leverage conditional exports.
I'm not delighted with the current state of things related to browser vs Node.js lands support.

@P0lip P0lip enabled auto-merge (squash) January 12, 2021 16:59
@P0lip P0lip merged commit ec81a92 into develop Jan 12, 2021
@P0lip P0lip deleted the fix/no-webpack-warnings branch January 12, 2021 17:06
@dimitropoulos dimitropoulos mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billiegoose billiegoose billiegoose approved these changes

@philsturgeon philsturgeon Awaiting requested review from philsturgeon

Assignees

@P0lip P0lip

Labels
t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings critical dependency with webpack
3 participants
@P0lip @billiegoose @philsturgeon