-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(repo): update rulesets docs #2310
Conversation
@philsturgeon would you mind taking a look at this and telling me what you think? I took a pass at reorganizing the Rulesets and Custom Rulesets page. I think there's still some work to do here in the Custom Rulesets Overview page (some reorganizing and rewriting), but want to get your thoughts before I make more changes. This link should work to see it in the docs view: https://docs.stoplight.io/docs/spectral/branches/docs%2Freorganize-rulesets/01baf06bdd05a-rulesets |
Custom Rulesets starts with this which no longer makes sense in the move:
Let's start from scratch. Lets look through the various keywrods that make up a ruleset, so you can learn to tweak a distributed ruleset to work for you, or make your own ruleset from scratch to power your organizations API Style Guide or some other custom situation. |
Generally this is looking amazing! Using a group is a fantastic way to break it down. |
Btw I noticed an old mistake I made, I had From @P0lip:
|
@philsturgeon thanks!! I fixed the I'll go ahead and update the intro to Custom Rulesets and make some more changes then. I'll tag you again once it's ready for another look. :) |
@philsturgeon I think it's ready for another look if you have some time? :D
I don't love having the Rulesets group now with: Overview, Rules, and then specific pages for certain Ruleset Properties (Aliases, etc.), but I'm not sure having a subgroup in there is a good idea... I'm thinking if this seems like a better organization, I could also stop at this point for this PR and just fix the links, and we can play around with a bit more in a separate PR. Let me know what you think! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great updates!
@@ -0,0 +1,110 @@ | |||
## JavaScript Ruleset Format | |||
|
|||
Spectral v6.0 added support for a JavaScript ruleset format, similar to the JSON and YAML formats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I asked before. Do we need the v6.0 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did, and I tagged other folks in that comment but didn't get a reply, so it stayed in there since I wasn't sure if it was ok to remove.
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #2231.
Preview link:
Checklist
Does this PR introduce a breaking change?