Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repo): add API Stylebook to README #2346

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Conversation

heitortsergent
Copy link
Contributor

Fixes #2315.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@heitortsergent heitortsergent self-assigned this Nov 21, 2022
@heitortsergent heitortsergent marked this pull request as ready for review November 21, 2022 22:01
@heitortsergent heitortsergent requested a review from a team as a code owner November 21, 2022 22:01
pamgoodrich
pamgoodrich previously approved these changes Nov 21, 2022
Copy link
Contributor

@pamgoodrich pamgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few suggestions

README.md Outdated
- [OWASP Top 10](https://apistylebook.stoplight.io/docs/owasp-top-10) - Set of rules to enforce [OWASP security guidelines](https://owasp.org/www-project-api-security/).
- [URL Style Guidelines](https://apistylebook.stoplight.io/docs/url-guidelines) - Set of rules to help developers make better and consistent endpoints.

And there are also rulesets created by many companies to improve their APIs. You can use these as is to lint your OpenAPI descriptions, or use these as a reference to learn more about what rules you would want in your own ruleset:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove the "And" at the beginning of the sentence since you have also. So it would read "There are also rulesets..."

README.md Outdated
- [Adidas](https://github.com/adidas/api-guidelines/blob/master/.spectral.yml) - Adidas were one of the first companies to release their API Style Guide in a written guide _and_ a Spectral ruleset. Lots of good rules to try in here.
- [APIs You Won't Hate](https://github.com/apisyouwonthate/style-guide) - An opinionated collection of rules based on advice in the [APIs You Won't Hate](https://apisyouwonthate.com/) community.
- [Azure](https://github.com/Azure/azure-api-style-guide/blob/main/spectral.yaml) - Ruleset and complimentary style guide for creating OpenAPI 2 or 3 definitions of Azure services.
- [Box](https://github.com/box/box-openapi/blob/main/.spectral.yml) - Lots of [Custom Functions](https://meta.stoplight.io/docs/spectral/ZG9jOjI1MTkw-custom-functions) being used to enforce good practices that the Box API governance folks are interested in.
- [DigitalOcean](https://github.com/digitalocean/openapi/blob/main/spectral/ruleset.yml) - Keeping their OpenAPI nice and tidy, enforcing use of `$ref` (probably to minimize conflicts), naming conventions for Operation IDs, and all sorts of other handy OpenAPI tips.
- [Tranascom](https://github.com/transcom/mymove/blob/master/swagger-def/.spectral.yml) - Don't even think about using anything other than `application/json`.
- [Zalando](https://apistylebook.stoplight.io/docs/zalando-restful-api-guidelines) - Based on [Zalando's RESTFUL API Guidelines](https://github.com/zalando/restful-api-guidelines), covers a wide-range of API topics such as versioning standards, properties naming standards, the default format for request/response properties, and more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

properties naming standards > property naming standards?

@heitortsergent heitortsergent merged commit fe3bbbf into develop Nov 22, 2022
@heitortsergent heitortsergent deleted the docs/readme-rulesets branch November 22, 2022 15:23
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add Stoplight public style guides to README
3 participants