fix(rulesets): avoid false errors from ajv #2407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the oasExample function so that example fields are removed from the schema to be used for validation. This is needed because the presence of an "example" field in a schema confuses ajv in certain scenarios. References: - stoplightio#2081 - stoplightio#2140 - ajv-validator/ajv#1426
padamstx
commented
Feb 22, 2023
| @@ -39,7 +39,8 @@ | |||
| "test.karma": "karma start", | |||
| "prepare": "husky install", | |||
| "prerelease": "patch-package", | |||
| "release": "yarn prerelease && yarn workspaces foreach run release" | |||
| "release": "yarn prerelease && yarn workspaces foreach run release", | |||
| "jest": "jest" | |||
There was a problem hiding this comment.
I added this simply to make it easy to run the jest that is installed in node_modules.
Example: yarn run jest packages/rulesets/src/oas/functions/__tests/oasExample.test.ts.
|
Closing this PR in favor of this PR. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2081
Checklist
Does this PR introduce a breaking change?
Additional context
This commit modifies the oasExample function so that example fields are removed from
the schema to be used for validation. This is needed because the presence of an "example" field in a schema confuses ajv in certain scenarios.
References: