fix(cli): do not return duplicate results #681
Conversation
| const ARTIFICIAL_ROOT = Symbol('root'); | ||
|
|
||
| const serializeRange = ({ start, end }: IRange) => `${start.line}:${start.character}:${end.line}:${end.character}`; | ||
| const getIdentifier = (result: IRuleResult) => `${result.path.join('/')}${result.code}${serializeRange(result.range)}`; |
There was a problem hiding this comment.
@P0lip Just an idea. How about turning that into a comparisonFunction (cf. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort)?
It could be used to detect duplicates in that use case (when === 0) and reused in stylish to order the results.
There was a problem hiding this comment.
My sincere apologies for dropping a ball on this one.
Your new WIP PR reminded me of this PR.
Seems like you've started some work on that, so how do you feel about merging this one and implementing the comparison fn in your PR?
There was a problem hiding this comment.
Seems like you've started some work on that
Well... I was merely scratching an itch to ensure my proposal was actually bringing some kind of value. 😉
so how do you feel about merging this one and implementing the comparison fn in your PR?
@P0lip 👍
Fixes #680
Checklist
Does this PR introduce a breaking change?