feat: toc start expanded #197
Conversation
mallachari
requested review from
a team and
marcelltoth
and removed request for
a team
src/TableOfContents/index.tsx
Outdated
| // expand items marked as initially expanded and its children | ||
| React.useEffect(() => { | ||
| const itemsToExpand = contents.filter(item => item.startExpanded); | ||
| const childrenToExpand = flatMap(itemsToExpand, item => | ||
| findDescendantIndices(item.depth ?? 0, contents.indexOf(item), contents.slice(contents.indexOf(item) + 1)), | ||
| ); | ||
|
|
||
| setExpanded(current => ({ | ||
| ...current, | ||
| ...Object.fromEntries(itemsToExpand.map(index => [index, true])), | ||
| ...Object.fromEntries(childrenToExpand.map(index => [index, true])), | ||
| })); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); |
There was a problem hiding this comment.
I don't buy why a prop called startExpanded would make children expanded.
Also is that required to adhere to the spec? It only wants you to expand individual APIs, not groups within, so that should be enough.
There was a problem hiding this comment.
And instead of hacking a useEffect, you could move the logic to line 108:
const [expanded, setExpanded] = React.useState({});and replace the empty initializer
There was a problem hiding this comment.
I understood Apis should start expanded as fully expanding its content with groups, but it might be just first level depth.
If we don't need to expand children then it will be simpler and without useEffect
There was a problem hiding this comment.
I don't think you need it all the way, that can get very messy quick
There was a problem hiding this comment.
Updated to be less greedy when expanding
|
🎉 This PR is included in version 3.0.0-beta.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Needed by stoplightio/elements#722
Adds support for initially expanded ToC items.