Some warnings fixed

stoqey · Mar 9, 2024 · 5ac46a8 · 5ac46a8
1 parent e1d5358
commit 5ac46a8
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -13,14 +13,18 @@ jobs:
     timeout-minutes: 3
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
       - name: Setup Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 18.17.1
+
       - name: Prepare
         run: yarn install --frozen-lockfile
+
       - name: Type Check
         run: yarn type-check
+
       - name: Lint Check
         run: yarn lint
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -12,13 +12,13 @@ jobs:
 
     steps:
       - name: "Checkout source code"
-        uses: "actions/checkout@v2"
+        uses: "actions/checkout@v4"
         with:
           ref: ${{ github.ref }}
 
       # Setup Node.js
       - name: "Setup Node.js"
-        uses: "actions/setup-node@v3"
+        uses: "actions/setup-node@v4"
         with:
           node-version: 18.17.1
 

diff --git a/src/tests/unit/api-next-live/get-contract-details.test.ts b/src/tests/unit/api-next-live/get-contract-details.test.ts
@@ -16,7 +16,6 @@ describe("ApiNext: getContractDetails()", () => {
 
   const clientId = Math.floor(Math.random() * 32766) + 1; // ensure unique client
 
-  let subscription$: Subscription;
   let api: IBApiNext;
   let error$: Subscription;
 

diff --git a/src/tests/unit/api/order/placeOrder.test.ts b/src/tests/unit/api/order/placeOrder.test.ts
@@ -62,7 +62,7 @@ describe("Place Orders", () => {
       refId = orderId;
       ib.placeOrder(refId, refContract, refOrder);
     })
-      .on(EventName.openOrder, (orderId, contract, order, orderState) => {
+      .on(EventName.openOrder, (orderId, contract, order, _orderState) => {
         if (orderId == refId) {
           expect(contract.symbol).toEqual(refContract.symbol);
           expect(order.totalQuantity).toEqual(refOrder.totalQuantity);
@@ -131,7 +131,7 @@ describe("Place Orders", () => {
       refId = orderId;
       ib.placeOrder(refId, refContract, refOrder);
     })
-      .on(EventName.openOrder, (orderId, contract, order, orderState) => {
+      .on(EventName.openOrder, (orderId, contract, order, _orderState) => {
         if (orderId == refId) {
           expect(contract.symbol).toEqual(refContract.symbol);
           expect(order.totalQuantity).toEqual(refOrder.totalQuantity);