Allow undefined for all OrderCancel properties

stoqey · Nov 16, 2024 · 73bcccf · 73bcccf
1 parent 8f4f78f
commit 73bcccf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/api/api.ts b/src/api/api.ts
@@ -385,7 +385,7 @@ export class IBApi extends EventEmitter {
     let orderCancel: OrderCancel;
     if (orderCancelParam == undefined)
       orderCancel = {
-        manualOrderCancelTime: "",
+        manualOrderCancelTime: undefined,
         extOperator: "",
         manualOrderIndicator: undefined,
       };
@@ -881,7 +881,7 @@ export class IBApi extends EventEmitter {
     this.controller.schedule(() =>
       this.controller.encoder.reqGlobalCancel(
         orderCancel || {
-          manualOrderCancelTime: "",
+          manualOrderCancelTime: undefined,
           extOperator: "",
           manualOrderIndicator: undefined,
         },

diff --git a/src/api/order/orderCancel.ts b/src/api/order/orderCancel.ts
@@ -2,7 +2,7 @@
  * Type describing the parameters of an order cancel
  */
 export interface OrderCancel {
-  manualOrderCancelTime: string;
-  extOperator: string;
-  manualOrderIndicator: number;
+  manualOrderCancelTime?: string;
+  extOperator?: string;
+  manualOrderIndicator?: number;
 }
diff --git a/src/core/io/encoder.ts b/src/core/io/encoder.ts
@@ -535,7 +535,7 @@ function tagValuesToTokens(tagValues: TagValue[]): unknown[] {
   cancelOrder(orderId: number, orderCancel: OrderCancel): void {
     if (
       this.serverVersion < MIN_SERVER_VER.MANUAL_ORDER_TIME &&
-      orderCancel.manualOrderCancelTime.length
+      orderCancel.manualOrderCancelTime?.length
     ) {
       return this.emitError(
         "It does not support manual order cancel time attribute",
@@ -568,7 +568,7 @@ function tagValuesToTokens(tagValues: TagValue[]): unknown[] {
     tokens.push(orderId);
 
     if (this.serverVersion >= MIN_SERVER_VER.MANUAL_ORDER_TIME)
-      tokens.push(orderCancel.manualOrderCancelTime);
+      tokens.push(orderCancel.manualOrderCancelTime ?? "");
 
     if (
       this.serverVersion >= MIN_SERVER_VER.RFQ_FIELDS &&
@@ -580,7 +580,7 @@ function tagValuesToTokens(tagValues: TagValue[]): unknown[] {
     }
 
     if (this.serverVersion >= MIN_SERVER_VER.CME_TAGGING_FIELDS) {
-      tokens.push(orderCancel.extOperator);
+      tokens.push(orderCancel.extOperator ?? "");
       tokens.push(orderCancel.manualOrderIndicator ?? Integer_MAX_VALUE);
     }
 
@@ -2251,7 +2251,7 @@ function tagValuesToTokens(tagValues: TagValue[]): unknown[] {
     }
 
     if (this.serverVersion >= MIN_SERVER_VER.CME_TAGGING_FIELDS) {
-      tokens.push(orderCancel.extOperator);
+      tokens.push(orderCancel.extOperator ?? "");
       tokens.push(orderCancel.manualOrderIndicator ?? Integer_MAX_VALUE);
     }