Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market scanner #169

Merged
merged 18 commits into from
Sep 14, 2023
Merged

Market scanner #169

merged 18 commits into from
Sep 14, 2023

Conversation

Tsopic
Copy link
Member

@Tsopic Tsopic commented Feb 15, 2023

  • Adds market scanner

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8457 lines exceeds the maximum allowed for the inline comments feature.

/**
* Start the app.
*/
start(): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function start has 26 lines of code (exceeds 25 allowed). Consider refactoring.

@rylorin rylorin marked this pull request as ready for review September 9, 2023 15:37
/**
* Start the app.
*/
start(): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function start has 29 lines of code (exceeds 25 allowed). Consider refactoring.

/**
* Start the app.
*/
start(): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

/**
* Print a warning message
*/
warn(text: string): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

/**
* Print an wainformation message
*/
info(text: string): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

/**
* Print an wainformation message
*/
debug(text: string): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit 9d892cd and detected 37 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 32
Duplication 5

View more on Code Climate.

@rylorin rylorin merged commit 023965c into master Sep 14, 2023
@rylorin rylorin deleted the market-scanner branch September 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants