-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue "Decoding error on COMPLETED_ORDER #201" fixed #202
Conversation
@@ -43,13 +45,12 @@ describe("IBApi Market data Tests", () => { | |||
code !== ErrorCode.REQ_MKT_DATA_NOT_AVAIL && | |||
code !== ErrorCode.DISPLAYING_DELAYED_DATA; | |||
|
|||
it("Stock market data", (done) => { | |||
it("ETF market data", (done) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 4 locations. Consider refactoring.
@@ -71,13 +72,12 @@ | |||
ib.connect().reqMarketDataType(MarketDataType.DELAYED_FROZEN); | |||
}); | |||
|
|||
it("SPY market data", (done) => { | |||
it("Stock market data", (done) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 4 locations. Consider refactoring.
} | ||
}); | ||
|
||
test("Stock contract details", (done) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
}); | ||
}); | ||
|
||
test("Future contract details", (done) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
}); | ||
}); | ||
|
||
test("Option contract details", (done) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
Code Climate has analyzed commit 2b445f6 and detected 0 issues on this pull request. View more on Code Climate. |
Issue #201 fixed
Test cases improved
Packages upgrade