Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to more coherent naming #118

Merged
merged 6 commits into from
Apr 16, 2024
Merged

chore: switch to more coherent naming #118

merged 6 commits into from
Apr 16, 2024

Conversation

Gozala
Copy link
Collaborator

@Gozala Gozala commented Apr 8, 2024 •
edited
Loading

@Gozala Gozala changed the title Update interface chore: switch to more coherent naming Apr 8, 2024
Gozala
Gozala commented Apr 8, 2024
View reviewed changes
w3-blob.md Outdated Show resolved Hide resolved
Gozala
Gozala commented Apr 8, 2024
View reviewed changes
w3-blob.md Show resolved Hide resolved
@Gozala Gozala marked this pull request as ready for review April 8, 2024 22:32
@Gozala Gozala mentioned this pull request Apr 8, 2024
Closed
vasco-santos
vasco-santos requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the diagram iteration.

There are some inconsistencies between site and claim on the types. I assume we want to go with site

w3-blob.md Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
@vasco-santos vasco-santos mentioned this pull request Apr 9, 2024
Merged
Gozala
Gozala commented Apr 9, 2024
View reviewed changes
w3-blob.md Outdated Show resolved Hide resolved
@Gozala @vasco-santos
Apply suggestions from code review
f53502e 
Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
Gozala
Gozala commented Apr 9, 2024
View reviewed changes
w3-blob.md Show resolved Hide resolved
alanshaw
alanshaw approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from tweaks and corrections captured in comments.

w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Show resolved Hide resolved
w3-blob.md Show resolved Hide resolved
Gozala
Gozala commented Apr 12, 2024
View reviewed changes
w3-blob.md Outdated Show resolved Hide resolved
Gozala
Gozala commented Apr 12, 2024
View reviewed changes
w3-blob.md Outdated Show resolved Hide resolved
Gozala
Gozala commented Apr 12, 2024
View reviewed changes
w3-blob.md Outdated Show resolved Hide resolved
Gozala and others added 2 commits April 11, 2024 23:17
@Gozala
Apply suggestions from code review
a6c6cbc 
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
@Gozala
Update w3-blob.md
ee5344d
vasco-santos
vasco-santos approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gozala Gozala merged commit 599e06b into main Apr 16, 2024
2 checks passed
@Gozala Gozala deleted the fix/align-blob-with-impl branch April 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gozala @alanshaw @vasco-santos