Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

w3 ls infinite loop when number of items in a space is larger than default page size #48

Closed
travis opened this issue Mar 1, 2023 · 0 comments · Fixed by #50
Closed

w3 ls infinite loop when number of items in a space is larger than default page size #48

travis opened this issue Mar 1, 2023 · 0 comments · Fixed by #50
Assignees
@travis
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@travis
Copy link
Member

travis commented Mar 1, 2023

if you upload more than 20 things to a space, w3 ls will just list it over and over again forever
@travis travis added the kind/bug A bug in existing code (including security flaws) label Mar 1, 2023
@travis travis self-assigned this Mar 1, 2023
This was referenced Mar 1, 2023
Open
Merged
travis added a commit that referenced this issue Mar 1, 2023
@travis
fix: pass cursor to list in w3 ls
8ba4cc3 
fixes #48

I added a test for this, but the issue doesn't happen in our current mock impl. I can spend some more time to make the mock implementation support `--size` and `--cursor` but it's not clear to me that's the right move yet - feels a little like adding extra code just to make a  test fail.
@travis travis mentioned this issue Mar 1, 2023
Merged
@travis travis closed this as completed in #50 Mar 2, 2023
travis added a commit that referenced this issue Mar 2, 2023
@travis
fix: pass cursor to list in w3 ls (#50)
324e913 
fixes #48

I added a test for this, but the issue doesn't happen in our current
mock impl. I can spend some more time to make the mock implementation
support `--size` and `--cursor` but it's not clear to me that's the
right move yet - feels a little like adding extra code just to make a
test fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis travis

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass cursor to list in w3 ls storacha/w3cli
1 participant
@travis