Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ucan stream consumer store/add and store/remove count #151

Merged
merged 1 commit into from
Mar 14, 2023
Merged

feat: ucan stream consumer store/add and store/remove count #151

merged 1 commit into from
Mar 14, 2023

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Mar 7, 2023 •
edited
Loading

Part of metrics work #117

Adds system total metrics for store/add and store/remove. With these, we can track number of CARs that we commited to store, and how many were removed.

Other notes:

  • we will still need to collect the effective number of CARs that are stored given this metrics is just number of signed URLs we provided in store/add.
  • helper functions for database were moved around to be re-used in all tests for metrics

@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from b500fe3 to c3e7746 Compare March 7, 2023 11:21
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from c3e7746 to 4def176 Compare March 7, 2023 13:40
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from 4def176 to 9416ad3 Compare March 7, 2023 13:45
@seed-deploy seed-deploy bot temporarily deployed to pr151 March 7, 2023 13:46 Inactive
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from 9416ad3 to 2d5315e Compare March 7, 2023 13:51
@seed-deploy
Copy link

seed-deploy bot commented Mar 7, 2023

View stack outputs

  • pr151-w3infra-CarparkStack

    Name Value
    BucketName carpark-pr151-0
    Region us-east-2

  • pr151-w3infra-SatnavStack

    Name Value
    BucketName satnav-pr151-0
    Region us-east-2

  • pr151-w3infra-UploadApiStack

    Name Value
    ApiEndpoint https://bq53sx9wc9.execute-api.us-east-2.amazonaws.com
    CustomDomain https://pr151.up.web3.storage

  • pr151-w3infra-BusStack

  • pr151-w3infra-ReplicatorStack

  • pr151-w3infra-UcanInvocationStack

  • pr151-w3infra-UploadDbStack

@seed-deploy seed-deploy bot temporarily deployed to pr151 March 7, 2023 13:52 Inactive
@vasco-santos vasco-santos requested a review from alanshaw March 7, 2023 14:11
@vasco-santos vasco-santos added this to the w3up phase 3 milestone Mar 7, 2023
@vasco-santos vasco-santos mentioned this pull request Mar 7, 2023
Closed
18 tasks
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from 2d5315e to d5216d5 Compare March 9, 2023 08:56
@seed-deploy seed-deploy bot temporarily deployed to pr151 March 9, 2023 08:56 Inactive
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch 2 times, most recently from 37b87bf to af1b82c Compare March 9, 2023 08:57
@seed-deploy seed-deploy bot temporarily deployed to pr151 March 9, 2023 09:01 Inactive
This was referenced Mar 9, 2023
Closed
Merged
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from af1b82c to f2b3080 Compare March 13, 2023 08:35
@seed-deploy seed-deploy bot temporarily deployed to pr151 March 13, 2023 08:35 Inactive
@vasco-santos vasco-santos mentioned this pull request Mar 13, 2023
Merged
1 task
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from f2b3080 to 5c41307 Compare March 14, 2023 10:49
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-store-add-and-remove-total branch from 5c41307 to b804dce Compare March 14, 2023 10:52
@vasco-santos vasco-santos merged commit 57842a1 into main Mar 14, 2023
@vasco-santos vasco-santos deleted the feat/ucan-stream-consumer-store-add-and-remove-total branch March 14, 2023 10:55
@seed-deploy seed-deploy bot temporarily deployed to pr151 March 14, 2023 10:56 Inactive
vasco-santos added a commit that referenced this pull request Mar 14, 2023
@vasco-santos
feat: ucan stream consumer upload remove (#157)
7d1ff48 
Part of metrics work #117

Adds system total metrics for `upload/remove`. With these, we can track
number of uploads unlinked from space

Needs:
- [x] #151

---------

Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos added a commit that referenced this pull request Mar 15, 2023
@vasco-santos
feat: ucan stream consumer store/add and store/remove count (#151)
3e23499 
Part of metrics work #117

Adds system total metrics for `store/add` and `store/remove`. With
these, we can track number of CARs that we commited to store, and how
many were removed.

Other notes:
- we will still need to collect the effective number of CARs that are
stored given this metrics is just number of signed URLs we provided in
`store/add`.
- helper functions for database were moved around to be re-used in all
tests for metrics
vasco-santos added a commit that referenced this pull request Mar 15, 2023
@vasco-santos
feat: ucan stream consumer upload remove (#157)
55c635f 
Part of metrics work #117

Adds system total metrics for `upload/remove`. With these, we can track
number of uploads unlinked from space

Needs:
- [x] #151

---------

Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos added a commit that referenced this pull request Mar 16, 2023
@vasco-santos
feat: ucan stream consumer store remove size (#158)
6f8776b 
Part of metrics work #117

Adds system accumulated metric for `store/remove` size. With these, we
can track total size of CARs requested for deletion. Until we have
receipts, we will rely on the bucket to perform a Head request (given we
do not have GC as well for now)

Needs:
- [x] #151
@vasco-santos vasco-santos self-assigned this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees

@vasco-santos vasco-santos

Labels
None yet
Projects
None yet
Milestone
w3up phase 3
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @alanshaw