-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store and upload list with pagination support #28
feat: store and upload list with pagination support #28
Conversation
f4aa6d2
to
e1f9361
Compare
View stack outputs
|
e1f9361
to
23d2d49
Compare
23d2d49
to
efc2f68
Compare
efc2f68
to
c8c926f
Compare
c8c926f
to
35ec1c0
Compare
35ec1c0
to
b8c631f
Compare
b8c631f
to
85f940d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change here looks good to me, but I think we want the items to be ordered by the datetime they were added...right?
Update: I'm not sure about that, S3 does not provide it and nor does Cloudflare KV for example...
@alanshaw good shout. I did not know about these local indexes but looks like we should add them. It is also super easy to use with https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-dynamodb/interfaces/querycommandinput.html#indexname I am merging this and add in new PR, given this PR just paginates list and does not take into account sorting functionality |
Adds pagination for
store/list
andupload/list
relying on acursor
andsize
capability invocation parameters.Updates
access-client
to 6.0.0 https://github.com/web3-storage/w3protocol/releases/tag/access-v6.0.0 . Most notably, account was renamed to space and these changes are reflected here as wellNeeds:
Closes #16