Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store and upload list with pagination support #28

Merged

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Nov 18, 2022

Adds pagination for store/list and upload/list relying on a cursor and size capability invocation parameters.

Updates access-client to 6.0.0 https://github.com/web3-storage/w3protocol/releases/tag/access-v6.0.0 . Most notably, account was renamed to space and these changes are reflected here as well

Needs:

Closes #16

@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from f4aa6d2 to e1f9361 Compare November 21, 2022 11:11
@seed-deploy seed-deploy bot temporarily deployed to pr28 November 21, 2022 11:11 Inactive
@seed-deploy
Copy link

seed-deploy bot commented Nov 21, 2022

View stack outputs

@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from e1f9361 to 23d2d49 Compare November 22, 2022 14:47
@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from 23d2d49 to efc2f68 Compare November 22, 2022 15:14
@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from efc2f68 to c8c926f Compare November 22, 2022 15:36
@seed-deploy seed-deploy bot temporarily deployed to pr28 November 22, 2022 15:36 Inactive
@vasco-santos vasco-santos marked this pull request as ready for review November 22, 2022 15:37
@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from c8c926f to 35ec1c0 Compare November 22, 2022 15:39
@seed-deploy seed-deploy bot temporarily deployed to pr28 November 22, 2022 15:39 Inactive
@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from 35ec1c0 to b8c631f Compare November 22, 2022 15:45
@seed-deploy seed-deploy bot temporarily deployed to pr28 November 22, 2022 15:45 Inactive
@vasco-santos vasco-santos force-pushed the feat/store-and-upload-list-with-pagination-support branch from b8c631f to 85f940d Compare November 22, 2022 16:14
@seed-deploy seed-deploy bot temporarily deployed to pr28 November 22, 2022 16:14 Inactive
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here looks good to me, but I think we want the items to be ordered by the datetime they were added...right?

Update: I'm not sure about that, S3 does not provide it and nor does Cloudflare KV for example...

@vasco-santos
Copy link
Contributor Author

@alanshaw good shout. I did not know about these local indexes but looks like we should add them. It is also super easy to use with https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-dynamodb/interfaces/querycommandinput.html#indexname

I am merging this and add in new PR, given this PR just paginates list and does not take into account sorting functionality

@vasco-santos vasco-santos merged commit 42c6d0c into main Nov 22, 2022
@vasco-santos vasco-santos deleted the feat/store-and-upload-list-with-pagination-support branch November 22, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add store/list cursor for pagination
2 participants