feat!: return shards as array from upload/add
#56
Conversation
Change `upload/add` to return items with a `shards` array instead of expanding them out to many root#shard rows. Stores shards as a String Set in dynamo. Multiple invocations of `upload/add` with the same root store the union of all the shards from each invocation. Fixes #52 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
View stack outputs
|
Stack outputs updated
|
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
| } | ||
|
|
||
| export interface UploadTable { | ||
| exists: (space: DID, root: AnyLink) => Promise<boolean> | ||
| insert: (item: UploadItemInput) => Promise<UploadItemOutput[]> | ||
| insert: (item: UploadAddInput) => Promise<UploadAddResult> |
There was a problem hiding this comment.
Should we follow store pattern and use Output for return value?
There was a problem hiding this comment.
we've not got a consistent pattern yet. The store table abstraction doesn't have enough info to create the StoreAddResult as the service includes other field like status and the signed url... so we go
StoreAddInput -> StoreAddOutput -> StoreAddResult
whereas in for upload/add we already have all the info for the service level result. I'll split those types out to match if we need it.
I think maybe we don't need them if we are also storing the UCAN Log Table. But I might be missing out on something. Let's create an issue to get a broader group discussion on that without blocking this PR |
|
oh my. the test is failing because it takes more than a second for the function under test to write to the db and return the value, so where i give 1000ms grace for an |
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
- update tests and types to handle upload/list items with a shards array property. - update upload/add fn to return an UploadAddResponse as shards out may be more than shards in. - update README see also: storacha/w3infra#56 Signed-off-by: Oli Evans <oli@protocol.ai>
- update tests and types to handle upload/list items with a shards array property. - update upload/add fn to return an UploadAddResponse as shards out may be more than shards in. - update README see also: storacha/w3infra#56 Signed-off-by: Oli Evans <oli@protocol.ai>
Change
upload/addto return items with ashardsarray instead of expanding them out to many root#shard rows.Stores shards as a String Set in dynamo. Multiple invocations of
upload/addwith the same root store the union of all the shards from each invocation.Fixes up type definitions and some tidying up from #48
Removes
issuerandinvocationfrom upload/add response, we're not using them, and there is an open question of how to store them...Question
Fixes #52
License: MIT
Signed-off-by: Oli Evans oli@protocol.ai