Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update react uploads list example #195

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

travis
Copy link
Member

@travis travis commented Dec 16, 2022

one slightly weird thing about this is that I realized we need to manually call next to get the next page of results - not sure if that's intentional and we might want to add that to the react-uploads-list package for developer convenience

@travis travis requested a review from alanshaw December 16, 2022 19:24
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 642b68c:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

@travis travis force-pushed the fix/react-uploads-list branch from 6d4e4fc to 642b68c Compare December 16, 2022 19:35
@travis travis requested a review from yusefnapora December 16, 2022 19:36
@travis travis mentioned this pull request Dec 19, 2022
@travis
Copy link
Member Author

travis commented Dec 19, 2022

@natevw this is the PR with the react example fix

Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@jchris jchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants