feat: test examples in playwright #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use playwright and playwright-test to verify the examples run in a browser - have playwright-test fire up the vite preview server on a known port to serve the example - add github workflow - add tests for other examples - consider pulling tests up to parent dir and reuse the same e2e test for each ui flavour - fix safari bug in sign-in example where submitting the form errors and returns the user to the form instead of the verify message License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46ab8ea:
|
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Closed
olizilla
added a commit
that referenced
this pull request
Jan 11, 2023
- pulls example tests out to own dir to reuse them for each ui library. also explores using vitest to drive playwright tests. It's ok, but I think we want as little friction as possible for browser testing, and i'm now inclined to use @playwright/test instead after trying it in #238 and now i see it has support for what we need to do here https://playwright.dev/docs/test-advanced#projects and https://playwright.dev/docs/test-parameterize License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far i've just added a minimal e2e style test for the vue sign-in-up example, to show the pattern and get feedback. It's already found a bug there in safari which doesn't appear in firefox or chrome:
WIP on #150
TODO
License: MIT
Signed-off-by: Oli Evans oli@protocol.ai