-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement reverse paging #381
Merged
Merged
Commits on Feb 14, 2023
-
feat: implement reverse paging
Use the new `pre` caveat and `startCursor` and `endCursor` from storacha/w3infra#139 to implement reverse paging. One unsatisfying issue with this is that paging backwards reverses the order of items in the uploads list, and that edge conditions behave fairly confusingly. Not entirely sure what to do about this yet, so pushing up for some feedback. This currently only works with a bunch of custom service config and `file:/` dependencies that I am not pushing up for now.
Configuration menu - View commit details
-
Copy full SHA for 97b1ed1 - Browse repository at this point
Copy the full SHA 97b1ed1View commit details
Commits on Feb 16, 2023
-
fix: update to latest @web3-storage/upload-client
this brings in the necessary changes for reverse paging
Configuration menu - View commit details
-
Copy full SHA for 8db29b3 - Browse repository at this point
Copy the full SHA 8db29b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f4b1b4 - Browse repository at this point
Copy the full SHA 4f4b1b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71082f4 - Browse repository at this point
Copy the full SHA 71082f4View commit details
Commits on Feb 17, 2023
-
- use icons instead of word buttons - make edge cases seem less weird by not rendering 0 sized pages
Configuration menu - View commit details
-
Copy full SHA for 7e93971 - Browse repository at this point
Copy the full SHA 7e93971View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae8a236 - Browse repository at this point
Copy the full SHA ae8a236View commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8f6f7ea - Browse repository at this point
Copy the full SHA 8f6f7eaView commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 470daed - Browse repository at this point
Copy the full SHA 470daedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f928a4 - Browse repository at this point
Copy the full SHA 1f928a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.