fix: workaround ts bug & generate valid typedefs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Nov 16, 2022
vasco-santos
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [5.0.1](access-v5.0.0...access-v5.0.1) (2022-11-16) ### Bug Fixes * workaround ts bug & generate valid typedefs ([#169](#169)) ([0b02d14](0b02d14)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
added a commit
that referenced
this pull request
Nov 16, 2022
Same as #169 but for upload capabilities. Did also a quick look at generated types in other capabilities and they look fine. Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
This works arounds typescript bug microsoft/TypeScript#51548 which in turn caused storacha/ucanto#133 by exporting imported modules so that generated typedefs will have those references
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.1](access-v5.0.0...access-v5.0.1) (2022-11-16) ### Bug Fixes * workaround ts bug & generate valid typedefs ([#169](#169)) ([3f595af](3f595af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Same as #169 but for upload capabilities. Did also a quick look at generated types in other capabilities and they look fine. Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works arounds typescript bug microsoft/TypeScript#51548 which in turn caused storacha/ucanto#133 by exporting imported modules so that generated typedefs will have those references