chore: split packages/access-client/src/capabilities to new package @web3-storage/capabilities #218
Conversation
…m @web3-storage/capabilities
Deploying with
|
| Latest commit: |
5f97d52
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b9d7eb3.ucan-protocol.pages.dev |
| Branch Preview URL: | https://1669667995-caps-package.ucan-protocol.pages.dev |
…the respective package, not all of them
…ntains packages/capabilities
…d packages/capabilities" This reverts commit 285c177.
gobengo
force-pushed
the
1669667995-caps-package
branch
from
bd0bfe7
to
e60626c
Compare
Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
| @@ -28,7 +28,7 @@ jobs: | |||
| node-version: 18 | |||
| cache: 'pnpm' | |||
| - run: pnpm install | |||
| - run: pnpm run build | |||
| - run: pnpm -r --filter @web3-storage/access run build | |||
There was a problem hiding this comment.
actually now it need to be pnpm run build because access-client depends on capabilities
| strategy: | ||
| matrix: | ||
| pnpm-version: | ||
| - 7 | ||
| node-version: | ||
| - 18 | ||
| package: | ||
| - capabilities |
There was a problem hiding this comment.
it's what @Gozala had done in the code snippet he linked me to in his review :)
| - name: Typecheck | ||
| uses: gozala/typescript-error-reporter-action@v1.0.8 | ||
| with: | ||
| project: packages/${{matrix.package}}/tsconfig.json |
There was a problem hiding this comment.
i really do not like this action, it makes reviews harder if there are any ts errors, like reviewing a draft PR and pnpm run lint already does typechecking
| uses: gozala/typescript-error-reporter-action@v1.0.8 | ||
| with: | ||
| project: packages/${{matrix.package}}/tsconfig.json | ||
| - run: pnpm -r --filter @web3-storage/${{matrix.package}} run lint |
There was a problem hiding this comment.
needs - run: pnpm -r --filter @web3-storage/${{matrix.package}} run build
There was a problem hiding this comment.
ok I removed it based on this
| @@ -28,7 +28,7 @@ jobs: | |||
| node-version: 18 | |||
| cache: 'pnpm' | |||
| - run: pnpm install | |||
| - run: pnpm run build | |||
| - run: pnpm -r --filter @web3-storage/upload-client run build | |||
There was a problem hiding this comment.
revert this please, running build for all packages catches errors that local build doesnt
There was a problem hiding this comment.
looks like you reverted it. lmk if there's something more I should do
| "test:node": "mocha 'test/**/!(*.browser).test.js' -n experimental-vm-modules -n no-warnings", | ||
| "test:browser": "playwright-test 'test/**/!(*.node).test.js'", |
There was a problem hiding this comment.
do we have browser or node specific tests in this package ?
| }, | ||
| "eslintConfig": { | ||
| "extends": [ | ||
| "./node_modules/hd-scripts/eslint/preact.js" |
There was a problem hiding this comment.
this should be "./node_modules/hd-scripts/eslint/index.js"
…web3-storage/capabilities (#218) Motivation: * #80 To do: * [x] initial package split * [x] remove capabilities dir from packages/access-client and fix imports in access-client * [x] fix imports from other packages that were importing from access-client/capabilities * [x] consider splitting to `capabilities/{service}/types` not `capabilities/types` * decided not to unless requested (makes exports map even more complicated, can do later) * [x] GH actions should run tests on packages/capabilities * [x] .github/workflows/release.yml does npm/docs jobs if paths_released contains packages/capabilities Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
Motivation:
To do:
capabilities/{service}/typesnotcapabilities/types