Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packages/capabilities to .github/release-please-manifest.json #232

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Dec 1, 2022

Motivation:

Expected 5 releases, only found 4
⚠ Missing 1 paths: packages/capabilities
⚠ No version for path packages/capabilities

Theory:

  • maybe these errors are because I hadn't added this package to the manifest?

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe9bd1f
Status: ✅  Deploy successful!
Preview URL: https://41667f06.ucan-protocol.pages.dev
Branch Preview URL: https://1669920349-caps-manifest.ucan-protocol.pages.dev

View logs

@gobengo gobengo marked this pull request as ready for review December 1, 2022 18:51
@gobengo
Copy link
Contributor Author

gobengo commented Dec 1, 2022

seems harmless and is reversible

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this should do it!

@gobengo gobengo merged commit ccaf1ab into main Dec 1, 2022
@gobengo gobengo deleted the 1669920349-caps-manifest branch December 1, 2022 19:03
gobengo added a commit that referenced this pull request Dec 1, 2022
…check for conventional-commits names in PRs (#233)

Motivation:
* This didn't trigger a release-please
#232
* Investigate:
* hmmmm "✔ No user facing commits found since beginning of time -
skipping"
https://github.com/web3-storage/w3protocol/actions/runs/3587365143/jobs/6037622712#step:2:368
* Act
  * this PR adds a commit inside packages/capabilities
gobengo added a commit that referenced this pull request Apr 11, 2023
Motivation:
*
#80 (comment)
* trying to get release-please-action to generate a release PR for
packages/capabilities
* I would have expected it in this action, but there was [an
error](https://github.com/web3-storage/w3protocol/actions/runs/3587365143/jobs/6037622712#step:2:44)
```
Expected 5 releases, only found 4
⚠ Missing 1 paths: packages/capabilities
⚠ No version for path packages/capabilities
```

Theory:
* maybe these errors are because I hadn't added this package to the
manifest?
gobengo added a commit that referenced this pull request Apr 11, 2023
…check for conventional-commits names in PRs (#233)

Motivation:
* This didn't trigger a release-please
#232
* Investigate:
* hmmmm "✔ No user facing commits found since beginning of time -
skipping"
https://github.com/web3-storage/w3protocol/actions/runs/3587365143/jobs/6037622712#step:2:368
* Act
  * this PR adds a commit inside packages/capabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants