Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove wallet #248

Merged
merged 1 commit into from
Dec 5, 2022
Merged

chore: remove wallet #248

merged 1 commit into from
Dec 5, 2022

Conversation

hugomrdias
Copy link
Contributor

This will be the keyring

This will be the keyring
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cab95aa
Status:🚫  Build failed.

View logs

@hugomrdias hugomrdias temporarily deployed to dev December 5, 2022 12:56 Inactive
@hugomrdias hugomrdias merged commit e705dae into main Dec 5, 2022
@hugomrdias hugomrdias deleted the chore/remove-wallet branch December 5, 2022 14:46
hugomrdias added a commit that referenced this pull request Dec 6, 2022
Motivation:
* latest commit on main branch was failing release workflow
[here](https://github.com/web3-storage/w3protocol/actions/runs/3621669639/jobs/6105393187#step:2:35)
* I think it's because the release-please config/manifest still referred
to `package/wallet`, which this PR removes
* seems like logical followup to
#248

Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
gobengo pushed a commit that referenced this pull request Apr 11, 2023
This will be the keyring
gobengo added a commit that referenced this pull request Apr 11, 2023
Motivation:
* latest commit on main branch was failing release workflow
[here](https://github.com/web3-storage/w3protocol/actions/runs/3621669639/jobs/6105393187#step:2:35)
* I think it's because the release-please config/manifest still referred
to `package/wallet`, which this PR removes
* seems like logical followup to
#248

Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants