fix: handle Buffer serialization #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer has a toJSON implementation which is called before our replacer function when serialising. It's JSON form is an object like { type: 'Buffer, data: number[] }`.
This gets mangled in storage and does not get deserilaised in the reviver. I think we'd rather have UintA8Arrays everywhere so this PR fixes it so that it gets revived as that.
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Dec 9, 2022
hugomrdias
approved these changes
Dec 9, 2022
alanshaw
pushed a commit
that referenced
this pull request
Dec 13, 2022
🤖 I have created a release *beep* *boop* --- ## [9.1.0](access-v9.0.1...access-v9.1.0) (2022-12-13) ### Features * sync encode/decode delegations ([#276](#276)) ([ab981fb](ab981fb)) ### Bug Fixes * destructured save ([#272](#272)) ([a4f20a9](a4f20a9)) * handle Buffer serialization ([#277](#277)) ([6dc77ca](6dc77ca)) * make d1 spaces.metadata nullable and change to kysely ([#284](#284)) ([c8a9ce5](c8a9ce5)), closes [#280](#280) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Buffer has a toJSON implementation which is called before our replacer
function when serialising. It's JSON form is an object like `{ type:
'Buffer, data: number[] }`.
This means it doesn't get identfied as $bytes, and does not get
deserialised in the reviver. I think we'd rather have `Uint8Array`
everywhere so this PR fixes it so that it gets revived as that.
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [9.1.0](access-v9.0.1...access-v9.1.0) (2022-12-13) ### Features * sync encode/decode delegations ([#276](#276)) ([9d48372](9d48372)) ### Bug Fixes * destructured save ([#272](#272)) ([b6aaf9b](b6aaf9b)) * handle Buffer serialization ([#277](#277)) ([8e8f745](8e8f745)) * make d1 spaces.metadata nullable and change to kysely ([#284](#284)) ([7f09479](7f09479)), closes [#280](#280) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer has a toJSON implementation which is called before our replacer function when serialising. It's JSON form is an object like
{ type: 'Buffer, data: number[] }.This means it doesn't get identfied as $bytes, and does not get deserialised in the reviver. I think we'd rather have
Uint8Arrayeverywhere so this PR fixes it so that it gets revived as that.License: MIT
Signed-off-by: Oli Evans oli@protocol.ai