fix: fix client cli service did resolve #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
approved these changes
Dec 13, 2022
This was referenced Dec 13, 2022
alanshaw
pushed a commit
that referenced
this pull request
Dec 14, 2022
🤖 I have created a release *beep* *boop* --- ## [9.1.1](access-v9.1.0...access-v9.1.1) (2022-12-14) ### Bug Fixes * access-client/src/agent default PRINCIPAL is did:web:web3.storage ([#296](#296)) ([27f2f60](27f2f60)) * add support for did:web in the cli ([#301](#301)) ([885f7c1](885f7c1)) * fix client cli service did resolve ([#292](#292)) ([6be9608](6be9608)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
that referenced
this pull request
Dec 14, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](access-api-v4.0.0...access-api-v4.1.0) (2022-12-14) ### Features * access-api version route sets did=ucantoServerId and adds a signer prop ([#305](#305)) ([5eab262](5eab262)) * embedded key resolution ([#312](#312)) ([4da91d5](4da91d5)) * include ucanto server principal did as 'aud' key in /version endpoint ([#309](#309)) ([bf3b171](bf3b171)) ### Bug Fixes * access-api ctx.signer no longer uses env.DID. instead env.DID is only used for ucanto server id ([#303](#303)) ([93d7003](93d7003)) * access-api wrangler.toml sets DID env var in env.dev ([#297](#297)) ([c4ca459](c4ca459)) * access-client/src/agent default PRINCIPAL is did:web:web3.storage ([#296](#296)) ([27f2f60](27f2f60)) * add support for did:web in the cli ([#301](#301)) ([885f7c1](885f7c1)) * fix client cli service did resolve ([#292](#292)) ([6be9608](6be9608)) * use did:web key in root handler ([#311](#311)) ([537dc48](537dc48)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
hugomrdias
added a commit
that referenced
this pull request
Jan 31, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.0](capabilities-v2.1.0...capabilities-v2.2.0) (2023-01-30) ### Features * access-api forwards store/ and upload/ invocations to upload-api ([#334](#334)) ([b773376](b773376)) * **capabilities:** implement access/authorize and ./update caps ([#387](#387)) ([4242ce0](4242ce0)), closes [#385](#385) * embedded key resolution ([#312](#312)) ([4da91d5](4da91d5)) * update @ucanto/* to ~4.2.3 ([#405](#405)) ([50c0c80](50c0c80)) * update access-api ucanto proxy to not need a signer ([#390](#390)) ([71cbeb7](71cbeb7)) ### Bug Fixes * fix client cli service did resolve ([#292](#292)) ([6be9608](6be9608)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
We removed service DID resolution from the agent so CLI needs to pass in the DID now.
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [9.1.1](access-v9.1.0...access-v9.1.1) (2022-12-14) ### Bug Fixes * access-client/src/agent default PRINCIPAL is did:web:web3.storage ([#296](#296)) ([1dd7217](1dd7217)) * add support for did:web in the cli ([#301](#301)) ([a1f9e85](a1f9e85)) * fix client cli service did resolve ([#292](#292)) ([45e7ad4](45e7ad4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](access-api-v4.0.0...access-api-v4.1.0) (2022-12-14) ### Features * access-api version route sets did=ucantoServerId and adds a signer prop ([#305](#305)) ([7452839](7452839)) * embedded key resolution ([#312](#312)) ([45f367d](45f367d)) * include ucanto server principal did as 'aud' key in /version endpoint ([#309](#309)) ([45e19ca](45e19ca)) ### Bug Fixes * access-api ctx.signer no longer uses env.DID. instead env.DID is only used for ucanto server id ([#303](#303)) ([1155998](1155998)) * access-api wrangler.toml sets DID env var in env.dev ([#297](#297)) ([7f4082f](7f4082f)) * access-client/src/agent default PRINCIPAL is did:web:web3.storage ([#296](#296)) ([1dd7217](1dd7217)) * add support for did:web in the cli ([#301](#301)) ([a1f9e85](a1f9e85)) * fix client cli service did resolve ([#292](#292)) ([45e7ad4](45e7ad4)) * use did:web key in root handler ([#311](#311)) ([d7bdade](d7bdade)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.0](capabilities-v2.1.0...capabilities-v2.2.0) (2023-01-30) ### Features * access-api forwards store/ and upload/ invocations to upload-api ([#334](#334)) ([6be7217](6be7217)) * **capabilities:** implement access/authorize and ./update caps ([#387](#387)) ([ebe1032](ebe1032)), closes [#385](#385) * embedded key resolution ([#312](#312)) ([45f367d](45f367d)) * update @ucanto/* to ~4.2.3 ([#405](#405)) ([ec39443](ec39443)) * update access-api ucanto proxy to not need a signer ([#390](#390)) ([163fb74](163fb74)) ### Bug Fixes * fix client cli service did resolve ([#292](#292)) ([45e7ad4](45e7ad4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
- codesansbox ci now support node 18 - disable `buildCommand` as it is done after install by the prepare lifecycle script see: https://codesandbox.io/docs/learn/sandboxes/ci#configuration-format fixes storacha#237 note: there is an issue to consolidate the examples in storacha#256 but our current set of examples are linked to from beta.ui.web3.storage so if we can get them working again without too much pain I think we should. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai> Signed-off-by: Oli Evans <oli@protocol.ai> Co-authored-by: Travis Vachon <travis.vachon@gmail.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
- codesansbox ci now support node 18 - disable `buildCommand` as it is done after install by the prepare lifecycle script see: https://codesandbox.io/docs/learn/sandboxes/ci#configuration-format fixes storacha#237 note: there is an issue to consolidate the examples in storacha#256 but our current set of examples are linked to from beta.ui.web3.storage so if we can get them working again without too much pain I think we should. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai> Signed-off-by: Oli Evans <oli@protocol.ai> Co-authored-by: Travis Vachon <travis.vachon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed service DID resolution from the agent so CLI needs to pass in the DID now.