feat: rm upload-api-proxy ability to route to separate environment audiences #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and did:web:staging.web3.storage audiences
gobengo
changed the title
|
@hugomrdias does this fulfill what you asked for here? |
hugomrdias
suggested changes
Jan 31, 2023
| @@ -60,7 +60,7 @@ unsafe = { bindings = [ | |||
| [env.staging] | |||
| name = "w3access-staging" | |||
| workers_dev = true | |||
| vars = { ENV = "staging", DEBUG = "false", DID = "did:web:staging.web3.storage" } | |||
| vars = { ENV = "staging", DEBUG = "false", DID = "did:web:staging.web3.storage", UPLOAD_API_URL = "https://staging.up.web3.storage" } | |||
There was a problem hiding this comment.
we should define this in all 4 envs
There was a problem hiding this comment.
like this? a0f07b5
afaict upload-api doesn't have a 'dev' environment so I pointed it to upload-api staging
Comment on lines
78
to
81
| // use production environment | ||
| ...uploadApiEnvironments.production, | ||
| ...(uploadApi.production && { url: uploadApi.production }), | ||
| fetch, | ||
| }), | ||
| [uploadApiEnvironments.staging.audience]: createUcantoHttpConnection({ | ||
| ...uploadApiEnvironments.staging, | ||
| url: uploadApi.staging ?? uploadApiEnvironments.staging.url, | ||
| // but override uploadApi.url from configuration, if provided | ||
| ...uploadApi.ucanto, |
There was a problem hiding this comment.
do we still need this function ? can't we just create a connection here https://github.com/web3-storage/w3protocol/blob/main/packages/access-api/src/utils/context.js#L48 ?
There was a problem hiding this comment.
I removed this default behavior by making the relevant options required and removed this function. cc94bad#diff-969dad085be9e4a6140a50e5f0142a0e6f106b12a5c3375f5857006fbe71dab8L74
| @@ -55,8 +54,7 @@ export interface RouteContext { | |||
| validations: Validations | |||
| } | |||
| uploadApi: { | |||
| production?: URL | |||
| staging?: URL | |||
| ucanto?: { url: URL } | |||
There was a problem hiding this comment.
maybe we should just have the connection in the context directly
There was a problem hiding this comment.
I did it here, wdyt? cc94bad#diff-a7cd4d05e6cba234e750cd72e2c9301b4cecec823d94002c39e928edd73b5b41L56
…just the url. also remove some code
travis
pushed a commit
that referenced
this pull request
Feb 16, 2023
🤖 I have created a release *beep* *boop* --- ## [4.10.0](access-api-v4.9.0...access-api-v4.10.0) (2023-02-16) ### Features * add support for access/authorize and update ([#392](#392)) ([9c8ca0b](9c8ca0b)), closes [#386](#386) * optional override for Postmark email From: field ([#354](#354)) ([f6b2350](f6b2350)) * rm /reproduce-cloudflare-error route ([#426](#426)) ([99cbd2f](99cbd2f)) * rm upload-api-proxy ability to route to separate environment audiences ([#407](#407)) ([5cfe274](5cfe274)) ### Bug Fixes * align postmark/welcome.txt with .html version ([#431](#431)) ([a53d6e6](a53d6e6)) * avoid email delegation via GET request ([#430](#430)) ([d282d6a](d282d6a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
…diences (#407) Motivation: * #406 * tl;dr remove some code/behavior that's not strictly needed and @hugomrdias asked me to remove
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [4.10.0](access-api-v4.9.0...access-api-v4.10.0) (2023-02-16) ### Features * add support for access/authorize and update ([#392](#392)) ([bf41071](bf41071)), closes [#386](#386) * optional override for Postmark email From: field ([#354](#354)) ([00db0ec](00db0ec)) * rm /reproduce-cloudflare-error route ([#426](#426)) ([158f309](158f309)) * rm upload-api-proxy ability to route to separate environment audiences ([#407](#407)) ([eefb6c6](eefb6c6)) ### Bug Fixes * align postmark/welcome.txt with .html version ([#431](#431)) ([0d72795](0d72795)) * avoid email delegation via GET request ([#430](#430)) ([e0f67e8](e0f67e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: