upgrade ucanto in authorize feat branch #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we'll want to make higher level combinations of these at some point, but this translates the various operations from @Bengo's observable (https://observablehq.com/d/95bfec64fbb3c2d1) into functions that clients can use
Motivation: * there weren't any tests that test access-api + access-client agent, so this adds a stub for one * it includes a lot of type adjustments that should make it easier to write more tests in followup * specifically it removed some old types I had tried to make when testing access delegate. I added a new `ServiceInvoke` type that is better than the ones I had made before. This is useful for making an 'invoke' function that will handle a subset of the caps available on `Service` but expect the same success/fail types as Service
1) save session principal in agent data 2) delegate more permissions from space to account (I think this is working?) 3) add newCreateSpace that can be renamed to get this working with the cli I haven't tested actual space uploads yet, but moving on to that next!
… registerSpaces + validate-email handler (#530) Previously a lot of logic to handle `access/confirm` was in the `validate-email` flow, since that is the most common place we'd receive that invocation (after clicking email sent by `access/authorize` handler). However, this logic can be expressed as a `ServiceMethod` on invocation of `access/confirm`, and validate-email can call that. This allows us to also self-issue `access/confirm` in some tests, e.g. in ucanto-test-utils `registerSpaces` and send it to our service to handle, which is only enabled when node env is TEST for now. Benefits: * wherever we use ucanto-test-utils `registerSpaces`, we'll be accurately testing the `access/confirm` + `provider/add` flow (not old/deprecated `voucher/redeem`) --------- Co-authored-by: Travis Vachon <travis@dag.house>
1) use new allows method from a ucanto branch to do so 2) throw errors in new space create flow if we adding a provider or delegating access fails 3) claim delegations after authorizing
This reverts commit 78cb8bf.
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [5.0.0](storacha/w3ui@react-uploader-v4.2.0...react-uploader-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ### Features * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ([8e7321b](storacha/w3ui@8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [5.0.0](storacha/w3ui@react-uploader-v4.2.0...react-uploader-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ### Features * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ([4449018](storacha/w3ui@4449018)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.