-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get access/claim
authorization wait function working
#666
Merged
Commits on Mar 28, 2023
-
feat: get
access/claim
authorization wait function workingBuild on @Bengo's `access/claim`-polling-based `waitForDelegationOnSocket` replacement. This will let us replace the websocket-based authorization wait function which makes the UX much more responsive - rather than waiting an indeterminate amount of time after clicking the email link, the process completes almost immediately with this change. The wait function is also pluggable so we that clients can implement different polling strategies, which should make it easier to test and use a receipt-based version of this in the future.
Configuration menu - View commit details
-
Copy full SHA for 121549a - Browse repository at this point
Copy the full SHA 121549aView commit details -
Configuration menu - View commit details
-
Copy full SHA for da72187 - Browse repository at this point
Copy the full SHA da72187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8353847 - Browse repository at this point
Copy the full SHA 8353847View commit details -
Configuration menu - View commit details
-
Copy full SHA for 409beb5 - Browse repository at this point
Copy the full SHA 409beb5View commit details -
feat: update w3up-client with new authorizeWaitAndClaim function
authorizeWaitAndClaim defaults to using the new `access/claim` polling based auth flow and and should react to email clicks much more quickly
Configuration menu - View commit details
-
Copy full SHA for 003ba9b - Browse repository at this point
Copy the full SHA 003ba9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 314cd0e - Browse repository at this point
Copy the full SHA 314cd0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2039008 - Browse repository at this point
Copy the full SHA 2039008View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1a2839 - Browse repository at this point
Copy the full SHA e1a2839View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1597de4 - Browse repository at this point
Copy the full SHA 1597de4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5777154 - Browse repository at this point
Copy the full SHA 5777154View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6796a46 - Browse repository at this point
Copy the full SHA 6796a46View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2761f9 - Browse repository at this point
Copy the full SHA a2761f9View commit details
Commits on Mar 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b832be8 - Browse repository at this point
Copy the full SHA b832be8View commit details -
fix: add a test that fails if the addProof default changes
per @Bengo's suggestion
Configuration menu - View commit details
-
Copy full SHA for 9146216 - Browse repository at this point
Copy the full SHA 9146216View commit details -
chore: naming tweak suggested by @alanshaw
plus use opts instead of options for consistency
Configuration menu - View commit details
-
Copy full SHA for 9bd6f7b - Browse repository at this point
Copy the full SHA 9bd6f7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a04bdc - Browse repository at this point
Copy the full SHA 9a04bdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6c12b4 - Browse repository at this point
Copy the full SHA b6c12b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0fe6ee - Browse repository at this point
Copy the full SHA c0fe6eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20aa56e - Browse repository at this point
Copy the full SHA 20aa56eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.